kafka-php icon indicating copy to clipboard operation
kafka-php copied to clipboard

Why fix client_id as 'kafka-php'? client_id is used in many scenarios.

Open icepigss opened this issue 7 years ago • 3 comments

I think this is a mistake

icepigss avatar Jul 24 '18 09:07 icepigss

@icepigss would you like to try to implement the possibility of changing the client-id?

lcobucci avatar Jul 24 '18 11:07 lcobucci

In my case, I need to change it because the server is restricted. Other than that, don't you find it a little weird that i change it but no effect. $config->setClientId("my_client");

icepigss avatar Jul 25 '18 09:07 icepigss

@icepigss I completely get your point and frustration. What I meant is that this is an open source library driven by the needs of the people who created it. So far nobody needed this feature, thus we don't have it.

Please take this as an invite to collaborate with us in this piece of software and get your need addressed in a more appropriated timeframe for you =)

lcobucci avatar Jul 25 '18 11:07 lcobucci