socialify icon indicating copy to clipboard operation
socialify copied to clipboard

Rename `descriptionEditable` to `description_overwrite` with backwards compatibility

Open wei opened this issue 10 months ago • 0 comments

  • [ ] Rename to descriptionEditable to description_overwrite to prettify url as snake_case is preferred over camelCase in urls.
  • [ ] Keep backwards compatibility so existing urls with descriptionEditable will still function as normal.
  • [ ] Instead of description_overwrite, Perhaps we can rename all variables to much shorter url parameters like i=1&f=1&d=1&do=Description%20Overwrite&t=Dark

https://github.com/wei/socialify/blob/5aed0122536b5e354c07ffba6f71f45c5b256884/common/types/queryType.ts#L14

https://github.com/wei/socialify/blob/5aed0122536b5e354c07ffba6f71f45c5b256884/src/components/configuration/config.tsx#L44-L60

https://github.com/wei/socialify/blob/5aed0122536b5e354c07ffba6f71f45c5b256884/src/components/configuration/config.tsx#L92-L99

This will come handy when adding language override too (https://github.com/wei/socialify/issues/69)

wei avatar Apr 13 '24 04:04 wei

@CryogenicPlanet wdyt? any other suggestion to make the query string parameter looking nicer?

wei avatar Apr 13 '24 04:04 wei