socialify icon indicating copy to clipboard operation
socialify copied to clipboard

Add border round

Open vLuckyyy opened this issue 1 year ago • 2 comments

Add option to change border-radius of output banner.

vLuckyyy avatar Jan 27 '23 22:01 vLuckyyy

Hey!

Happy to accept a PR for this too!

Steps:

  • Add a UI element to choose if they want a border-radius and what colour (for backwards compatibility the default should be no border-radius), this element would go here https://github.com/wei/socialify/blob/master/src/components/configuration/config.tsx
  • Ensure that this UI element is correctly updating the url, in this app all state is stored in the URL. You will need three parameters here, one which is a boolean for if border-radius is enabled (store this as 1 or 0), the hex code and the size of the border
  • Add a border radius to card.tsx to match the state in the url

Happy to help guide if you get stuck along the way

CryogenicPlanet avatar Jan 28 '23 14:01 CryogenicPlanet

Thanks, I'll try to do a PR, thanks for your help!

vLuckyyy avatar Jan 28 '23 15:01 vLuckyyy

Closing due to inactivity. Please reopen if there are any new developments on this.

wei avatar Apr 12 '24 03:04 wei