wegue icon indicating copy to clipboard operation
wegue copied to clipboard

infoClick on multiple visible features/layers

Open enricofer opened this issue 11 months ago • 3 comments

The pull request is about a new infoclick feature allowing to browse between multiple features detected on map visible layers Screenshot (230)

enricofer avatar Mar 13 '24 09:03 enricofer

Hi @enricofer, thank you for the contribution! I tested this briefly and it works well.

Could you please run npm run lint:fix once and commit the result. Some more comments inline.

Greets Felix

fschmenger avatar Mar 18 '24 16:03 fschmenger

Hi here I am, sorry for the noise and thank for your work.

enricofer avatar Mar 21 '24 07:03 enricofer

I had a quick look, what is wrong with the test: The line https://github.com/wegue-oss/wegue/blob/master/tests/unit/specs/components/infoclick/InfoClickWin.spec.js#L88 and following need to be changed to

map.forEachFeatureAtPixel = () => {
  vm.features.push([feat, layer]);
};

so the mock still reflects the current code.

chrismayer avatar Mar 27 '24 10:03 chrismayer

Hi @enricofer , do you see a chance that you push this forward? No fronts, this is not meant to put pressure on you. I know everybody has a lot to do. But this feature is too cool, to hang around here ;-) If you currently do not have time to push this forward, which is no problem, I'd happily take over here and finish this. Thanks for any feedback and your great work so far!

chrismayer avatar Apr 19 '24 08:04 chrismayer

I apologize at that moment I didn't understand the meaning of the code and I forgot to update the PR

enricofer avatar Apr 21 '24 08:04 enricofer