Ashley Engelund

Results 60 comments of Ashley Engelund

The jison files are definitely biggest, but this would be really easy first step. :-)

Glad you are posting this here, @brennanyoung . No apology needed IMNSHO: Sometimes we just don't learn things until later. (That's the real world!) Now that the structure is there...

There be tests added for this. That way this won't happen again. In general, if a feature is accidentally (or intentionally) removed or a bug is found, a test should...

@Aniket1026 - I just submitted PR #3814 that revises the instructions for contributing/developing. Can you please review it? I'd love your feedback. Hopefully I can incorporate your feedback and address...

Here's a workflow action that could be used: [Changed Files](https://github.com/marketplace/actions/changed-files)

Sure -- the native feature would work. What are the limits of how many dependencies are "too many"? It's a classic "build vs. buy" trade-off: someone else is responsible for...

I have some questions about this PR: 1. What is the purpose? I'm not clear on this 2. Your code doesn't change anything for the user ### 1. Purpose? Can...

Thanks for clarifying for me. Makes more sense now. (You'll still need to modify the parser `flow.jison`. But I think you understand that. :-) )

FYI to whomever works on this: The problem is occurring in `dagre-d3-es/dagre/rank/utils.js` `longestPath(g)`. In the `dfs` sub-function, "label" is undefined when v = "subgraph4" (g.node("subgraph4") is undefined).

@DanielOaks @qurm You both chimed in with #2910 so I'm pinging you to ask for your review. My eyes and brain are saturated and I really need some feedback. :-)...