DeepForest icon indicating copy to clipboard operation
DeepForest copied to clipboard

[WIP] Distribute config file from primary location

Open ethanwhite opened this issue 1 year ago • 1 comments

We had two copies of deepforest_config.yml. The first was the main copy in the root directory of the repo. The second was a copy that got distributed with the package. This is error prone and unnecessary since we can package directly from the root file.

Unless I'm misunderstanding #531 I think this should address it.

ethanwhite avatar Aug 11 '24 16:08 ethanwhite

This is currently broken because we're not actually testing against the installed package, we're testing against the source code, which doesn't have the data included. This is part of the same problem as #562. I'm going to open an issue to discuss the general solution

ethanwhite avatar Aug 11 '24 20:08 ethanwhite

This relates to a broader conversation that I would love to move to hydra, add argparse support for config. This is a 2.0 kinda thing, there may be a more short term patch here for the immediate need.

bw4sz avatar Oct 28 '24 16:10 bw4sz

Resolved by our move to src/deepforest structure

ethanwhite avatar Feb 26 '25 16:02 ethanwhite

Actually there's probably some cleanup in here that is still worth including so reopening to check if it still needs to be added

ethanwhite avatar Feb 26 '25 16:02 ethanwhite

@bw4sz & @henrykironde - this should finally complete our move to src/deepforest by reducing us to a single deepforest_config.yml. I did end up having to move it out of root, so I moved it to src/deepforest/deepforest_config.yml which I think makes sense. All other changes are in service of this move. I'd like you both to sign off on this one in case there's something weird about that file move that I failed to consider.

ethanwhite avatar Feb 28 '25 17:02 ethanwhite

And @henrykironde - once this is merged lets go ahead and roll a new release.

ethanwhite avatar Mar 01 '25 13:03 ethanwhite

I've rebased this again. @henrykironde can we please get this merged once the tests pass and roll a new release.

ethanwhite avatar Mar 12 '25 11:03 ethanwhite