Issue #569 fixed/Introduces 'path' as an alternative to 'raster_path'…

[Abhishek-kumar0503]

Issue #569 fixed

[bw4sz]

Thanks, running tests now.

[ethanwhite]

Thanks @Abhishek-kumar0503. As I noted in my overall review comment https://github.com/weecology/DeepForest/pull/617#pullrequestreview-1943695662 there are additional uses of raster_path that need to be updated and we need a test for this. Can you please add the test and then use it to check for other instances of raster_path that need to be changed.

[Abhishek-kumar0503]

okay @ethanwhite I created the function name def test_predict_tile_with_projection and add it in test

def test_predict_tile_with_projection(m, raster_path):
    # test with projection enabled
    m.config["train"]["fast_dev_run"] = False
    m.create_trainer()
    prediction, projection = m.predict_tile(raster_path=raster_path,
                                            patch_size=300,
                                            patch_overlap=0.1,
                                            return_plot=False,
                                            keep_projection=True)
    
    assert isinstance(prediction, pd.DataFrame)
    assert set(prediction.columns) == {"xmin","ymin","xmax","ymax","label","score","image_path"}
    assert not prediction.empty
    
    assert isinstance(projection, pd.DataFrame)  # Assert that projection dataframe is returned 

and i check it then it fails. Can you tell where is issue in it

[ethanwhite]

Thanks for adding the test. Have you tried debugging the resulting error? If so, where did you get stuck?

[Abhishek-kumar0503]

ya it give error in unnecessary data type keep_projection. Solved!

[ethanwhite]

Great! Can you rebase this to remove the merge conflicts and then I'll give it another look

[Abhishek-kumar0503]

@ethanwhite it give error in check style. Can you help me to solve this issue.

[ethanwhite]

@Abhishek-kumar0503 - try running this locally:

yapf -i --recursive deepforest/ --style=.style.yapf

That should cleanup the style issue.

[Abhishek-kumar0503]

yeah,thanks it worked

[ethanwhite]

Closing due to inactivity. Feel free to reopen if you return to this.