DeepForest icon indicating copy to clipboard operation
DeepForest copied to clipboard

Introduces 'path' as an alternative to 'raster_path' with a deprecation warning

Open manascb1344 opened this issue 2 years ago • 2 comments

manascb1344 avatar Dec 07 '23 14:12 manascb1344

Thanks for this PR. Just need to add 'path' to the doc string.

https://github.com/weecology/DeepForest/blob/2d2678bdff9b81fdf2b9c672546e0047032fe369/deepforest/main.py#L405

I've been setting DeepForest 2.0 as the Deprecation time for these function arguments.

closes https://github.com/weecology/DeepForest/issues/545

bw4sz avatar Dec 08 '23 00:12 bw4sz

Just need a doc string and specify that DeepForest 2.0 is the deprecation version for that arg. Thanks!

So are the changes enough or any more changes needed?

manascb1344 avatar Feb 05 '24 19:02 manascb1344

Thanks for the contribution @manascb1344. I'm going to close this PR in favor of #617 since this one just adds the argument but doesn't make all of the downstream changes to make that new argument work. Those changes are all completed in #617 if you want to see a complete set of changes for this issue looks like.

ethanwhite avatar Apr 28 '24 14:04 ethanwhite