DeepForest icon indicating copy to clipboard operation
DeepForest copied to clipboard

We need a test to ensure that setup.py is capturing all the modules.

Open bw4sz opened this issue 2 years ago • 1 comments

In #561 we ended up shipping a pypi version that didn't have a module deepforest.models. This is because it existed in the git repo and so passed all the tests, but wasn't properly passing. Is there a way to mock setup.py to create a tarball and then check if all the modules are in the tarball?

The key line is https://github.com/weecology/DeepForest/blob/450e051ef41f1812a64be72302d662c952d1d0fc/setup.py#L53

bw4sz avatar Dec 04 '23 23:12 bw4sz

Just came across this recommendation for directory structure to avoid this sort of issue: https://www.pyopensci.org/python-package-guide/package-structure-code/python-package-structure.html#the-src-layout-and-testing

ethanwhite avatar Jan 09 '24 18:01 ethanwhite

Fixed by moving to a src directory structure

ethanwhite avatar Apr 16 '25 01:04 ethanwhite