Subtitles icon indicating copy to clipboard operation
Subtitles copied to clipboard

Published 20 hours ago • verified publisher icon wecobble

Add simple support for new block editor

Open grappler opened this issue 5 years ago • 4 comments

Description

This is a temporary solution so that the Subtitles can still be edited in the new block editor(Gutenberg).

Don’t load styles & scripts on post types that do not support subtitles.

Related to #104

How Has This Been Tested?

I have tested this on WP 5.1.1 with Gutenberg enabled for posts, a CPT with Subtitles support but in the classic editor and a CPT without Subtitles support.

Screenshots (if applicable):

image

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • [x] My code is tested.
  • [x] My code follows the WordPress code style.
  • [x] My code has proper inline documentation.

grappler avatar Mar 19 '19 10:03 grappler

Hello,

Is it possible to use that branch in a production environment ? How ?

Thank you

lapineige avatar Jun 06 '20 09:06 lapineige

Yes, you can download that version from here: https://github.com/wearerequired/Subtitles/tree/temp-gutenberg-support

grappler avatar Jun 06 '20 09:06 grappler

Great, thanks for the tip :) (and the PR !)

lapineige avatar Jun 06 '20 10:06 lapineige

It works perfectly fine :)

lapineige avatar Jun 06 '20 11:06 lapineige