wechaty-puppet-padplus icon indicating copy to clipboard operation
wechaty-puppet-padplus copied to clipboard

add integration test for restart

Open huan opened this issue 6 years ago • 8 comments

Related to #189

huan avatar Mar 18 '20 15:03 huan

After added this version of the test, the unit test can pass but will hang forever.

The reason for it I guess might be the stop() did not clean all the resources that the puppet has used, for example, timers.

huan avatar Mar 18 '20 15:03 huan

Can we merge this PR for now?

huan avatar Mar 31 '20 17:03 huan

It can not pass test, maybe something wrong with stop(), I will check it later, and then when I resolved this problem, I will merge this PR with green CI.

su-chang avatar Apr 01 '20 01:04 su-chang

Can we merge this PR for now?

huan avatar Apr 07 '20 08:04 huan

Sorry, it can't.

It can not pass the CI test, because of no token for padplus start().

I do not know how to make it skip token verification.

su-chang avatar Apr 07 '20 09:04 su-chang

Understand.

So the question left for us is: How Might We merge this PR?

I hope we can figure it out soon.

huan avatar Apr 07 '20 09:04 huan

Maybe we could not pass the CI test after we revert flash-store to v0.14.1. Due to some bugs about segmentfault.

su-chang avatar Apr 08 '20 13:04 su-chang

I removed the memory-card for this test, and it could pass start and then stop three times.

But I do not know why it will hang npm test when all test passed.

su-chang avatar Apr 09 '20 06:04 su-chang