webview_rust icon indicating copy to clipboard operation
webview_rust copied to clipboard

update webview, use static lib on windows

Open MoAlyousef opened this issue 4 years ago • 2 comments

What kind of change does this PR introduce? (check at least one) This updates webview and also uses the static build of WebView2Loader instead of the dll on Windows. This means no need to copy the dll into the target dir, nor is it needed with deployment of webview apps.

  • [ ] Bugfix
  • [ ] Feature
  • [ ] New Binding Issue #___
  • [ ] Code style update
  • [ ] Refactor
  • [ x] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change? (check one) No the change doesn't affect the api of the library. It might affect workflows requiring the dll for deployment.

The PR fulfills these requirements:

  • [x ] It's submitted to the dev branch and not the master branch
  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

MoAlyousef avatar Aug 21 '21 01:08 MoAlyousef

Is there stuff blocking this? Just curious what the status of this is since the last activity on this was in Aug 2021.

josh-hemphill avatar Mar 23 '22 19:03 josh-hemphill

Is there stuff blocking this? Just curious what the status of this is since the last activity on this was in Aug 2021.

I tested it locally recently and it didn't work... but i don't know more than that

eliassjogreen avatar Mar 23 '22 21:03 eliassjogreen