webview_deno icon indicating copy to clipboard operation
webview_deno copied to clipboard

update WebView to support gtk 4

Open sigmaSd opened this issue 1 year ago • 4 comments

The latest WebView update uses webgtkkit 6 and gtk 4 would be great if this library updates to the latest version

sigmaSd avatar Oct 06 '24 16:10 sigmaSd

Yeah, webview is in need of some major refactoring and housekeeping. Haven't had the time nor motivation to update it in the last year or so... Help is ofc always welcome :)

eliassjogreen avatar Oct 08 '24 07:10 eliassjogreen

The good thing is the new release doesn't seem to have new breaking changes.

I dlopened the new library directly, and it wroked on linux, so it seems like its just a matter of updating the buildscript. (I confirmed its using gtk 4 using GTK_DEBUG=all)

I'm not familiar with cross building for mac and windows, so I can't help in this area for now.

sigmaSd avatar Oct 08 '24 10:10 sigmaSd

I haven't been involved in this project but I'll just say that the core webview library can currently be compiled to support one of the following, but not all at the same time:

  • GTK 4, WebKitGTK API 6.0
  • GTK 3, WebKitGTK API 4.1
  • GTK 3, WebKitGTK API 4.0

Note that some features aren't available anymore in GTK 4 and have no replacements.

SteffenL avatar Oct 09 '24 15:10 SteffenL

Looking at this now quickly I think the biggest problem is that we are using a 2 year old version of webview. We need to update the build scripts to support the latest webview and then we should be able to build for each variant. We should then probably build all of the different variants in matrix CI action, that way we can support each variant :)

eliassjogreen avatar Oct 09 '24 15:10 eliassjogreen

related: https://github.com/webview/webview_deno/issues/186

congzhangzh avatar Nov 26 '24 16:11 congzhangzh

fixed in https://github.com/webview/webview_deno/pull/189

sigmaSd avatar Feb 28 '25 10:02 sigmaSd