webview icon indicating copy to clipboard operation
webview copied to clipboard

Building DLLs in CI and publishing them via releases

Open abemedia opened this issue 5 years ago • 5 comments

We've had a number of issues with people using outdated DLLs. How about we delete them from the repo and instead have them built in CI, telling people to download them from releases? This way we can simply publish a new release whenever there's changes to the C code and don't have to worry about them being outdated.

Thoughts?

abemedia avatar Jul 31 '20 15:07 abemedia

This would probably help a ton of people. It's really confusing to have DLLs tracked in source code that are not up-to-date.

Is super easy to add a step to CI that uploads artifacts that can be dowloaded by anybody for every build: https://github.com/zicklag/webview/actions/runs/194039808.

Also, you could add the artifacts to each release.

zicklag avatar Aug 04 '20 13:08 zicklag

Based on the number of upvotes I'll take that as a yes then lol. Will probably sort out a PR tomorrow which adds the DLLs to the release. Thanks for your POC @zicklag

abemedia avatar Aug 04 '20 14:08 abemedia

Checking on on status for this - i'd rather be able to build the DLLs myself if possible or get it from official microsoft repositories

hqtsky avatar Feb 18 '21 16:02 hqtsky

Sorry this got totally forgotten. Was talking about the webview DLL though, not Edge.

abemedia avatar Feb 18 '21 18:02 abemedia

@abeMedia I'm a bit lost on which dll's are to be used as of 2021: csharp repository dlls, building them ourselves, or the ones in the webview repository? I've not played revisited this project since I had the issues, as I was hoping the DLL process would be resolved, but it seems like there are still issues:

https://github.com/webview/webview/issues/520 https://github.com/webview/webview/issues/487

eliveikis avatar Feb 26 '21 13:02 eliveikis