[Bug]: Enabling TLS on windows will cause non-found ssl

[avalyn0x45]

On my windows machine, whenever i try to compile with TLS enabled, zig says that it cannot find SSL or crypto, and that it has searched no paths. I have OpenSSL installed, an it is in path, and i have even tried directly linking libssl.

[AlbertShown]

I'm not sure how to use TLS with Zig build ! @jinzhongjia, I guess we should add an option for TLS include and lib paths.

.enable_tls = false,
.tls_include = "PATH_TO_TLS_INCLUDE",
.tls_lib = "PATH_TO_TLS_LIB",

However, a workaround for now, is to you can manually build a dynamic version of webui + TLS using any C compiler:

1. Clone webui repo
2. Build with TLS: nmake WEBUI_USE_TLS=1 WEBUI_TLS_INCLUDE="PATH_TO_TLS_INCLUDE" WEBUI_TLS_LIB="PATH_TO_TLS_LIB"
3. Build your Zig program .is_static = false,
4. Manually replace the .dll with the one that have TLS

Note:

• You can also download a trusted secure pre-compiled DLL + TLS (compiled by GitHub Workflow)
• Zig build does not support cross-compiling, or Musl, when using TLS build.

[AlbertShown]

Another thing, make sure you have OpenSSL v3.3.1+ if you still have issues, please share the compiling logs and details.

[avalyn0x45]

The pre-built files have the file webui-2.dll, while the program says it requires webui.dll, any idea why?

[avalyn0x45]

It also complains if I just rename the file.

[AlbertShown]

while the program says it requires webui.dll

Which program we are talking about here?

[avalyn0x45]

The program that utilizes zig-webui, which is currently just

const os = std.os;
const webui = @import("webui");

const main = @embedFile("main.html");

pub fn main() !void {
    var nwin = webui.newWindow();
    _ = nwin.show(main);
    webui.wait();
}

[avalyn0x45]

In case it matters, the build.zig is

const std = @import("std");

pub fn build(b: *std.Build) void {
    const target = b.standardTargetOptions(.{});
    const optimize = b.standardOptimizeOption(.{});
    const exe = b.addExecutable(.{
        .name = "main",
        .root_source_file = b.path("src/main.zig"),
        .target = b.host,
    });
    const zig_webui = b.dependency("zig-webui", .{
        .target = target,
        .optimize = optimize,
        .is_static = false,
    });
    exe.subsystem = .Windows;
    exe.root_module.addImport("webui", zig_webui.module("webui"));
    b.installArtifact(exe);
}

[jinzhongjia]

Yes, the problem does exist on Windows, but the root cause of the problem is in the upstream webui. The build of webui cannot correctly find system libraries on windows I won't be able to deal with this issue for a short time, but maybe I can let him take a look. @mochalins

[mochalins]

I'll take a look, thanks for the ping.

[jinzhongjia]

Past CI tests did not have tls testing. At least in the 0.11 period, tls was running normally. After the issue is resolved, you need to add the CI test of tls

[jinzhongjia]

After about two weeks, I have a lot of free time to deal with the deposition problem of this library.

[jinzhongjia]

OK,I'm back. I will try to fix it tomorrow

[jinzhongjia]

Well, I tried for a few hours and still didn't find the perfect solution. The zig compiler never found the ssl library correctly, even if the path was specified. I will make additional attempts when I have time

[AlbertShown]

I guess the solution may look something like this:

.enable_tls = true,
.tls_include = "PATH_TO_TLS_INCLUDE", // Example: C:\Program Files\OpenSSL-xxx\include
.tls_lib = "PATH_TO_TLS_LIB", // Example: C:\Program Files\OpenSSL-xxx\lib

Compiling webui with TLS on Windows:

...... WEBUI_USE_TLS=1 WEBUI_TLS_INCLUDE="v{}" WEBUI_TLS_LIB="v{}", .{ tls_include, tls_lib }

[AlbertShown]

WEBUI_TLS_INCLUDE="v{}" WEBUI_TLS_LIB="v{}"

Of course those are just an example, need to be changed to -I and -L.

[AlbertShown]

tls_include = "PATH_TO_TLS_INCLUDE", // Example: C:\Program Files\OpenSSL-xxx\include
.tls_lib = "PATH_TO_TLS_LIB", // Example: C:\Program Files\OpenSSL-xxx\lib

Those options need to be added, I guess.

[jinzhongjia]

Good idea, I will initiate a PR to the upstream and let webui's build.zig expose the option to set the location of the library

[jinzhongjia]

A very strange problem, the Zig's construction system cannot find a package in the LIB and INCLUDE directory I specified, but GCC can

[AlbertShown]

@jinzhongjia feel free to change anything in upstream Zig build file if this may help you fixing the SSL issue for Zig.

[jinzhongjia]

My previous attempt is to change directly in the upstream, but I still can't find the library.

[AlbertShown]

I will investigate in this, if I found a solution I will suggest it to you.