webtorrent-desktop icon indicating copy to clipboard operation
webtorrent-desktop copied to clipboard

Published 20 hours ago • verified publisher icon webtorrent

macOS: Create Universal application

Open Teutates opened this issue 2 years ago • 8 comments

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [ X ] Other, please explain: Adds arm64 arch to macOS build

What changes did you make? (Give an overview)

Add arm64 arch to macOS build to create a universal Intel/Apple Silicon app

Which issue (if any) does this pull request address?

#1907

Is there anything you'd like reviewers to focus on?

N/A

Teutates avatar Apr 05 '22 18:04 Teutates

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] avatar Apr 05 '22 18:04 welcome[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Jun 05 '22 12:06 github-actions[bot]

Is this still relevant?

Yes.

If so, what is blocking it?

@DiegoRBaquero is assigned and hasn't had any activity on this PR since April 5th. So @DiegoRBaquero is currently blocking this PR.

Is there anything you can do to help move it forward?

Hopefully tagging @DiegoRBaquero will help move this forward 😉.

Really want to see this!

fishcharlie avatar Jun 07 '22 16:06 fishcharlie

Can you please resolve the conflicts?

DiegoRBaquero avatar Jun 07 '22 16:06 DiegoRBaquero

@DiegoRBaquero Not sure I'm gonna be able to do that since I'm not the PR author.

@Teutates can you resolve the merge conflicts?

fishcharlie avatar Jun 07 '22 16:06 fishcharlie

@fishcharlie @DiegoRBaquero Does this do the trick?

Teutates avatar Jul 02 '22 16:07 Teutates

works fine here, i have successfully built webtorrent-desktop for arm64 macos

treeshateorcs avatar Jul 03 '22 02:07 treeshateorcs

Bumping @DiegoRBaquero

Teutates avatar Sep 02 '22 02:09 Teutates

If anyone is willing to run code from a random dude on the Internet until this PR gets merged and released, I’ve built the package with refs/pull/2190/merge checked out.

https://transfer.sh/xMRjmg/WebTorrent.zip

@DiegoRBaquero @Teutates is there anything blocking this PR?

tie avatar Oct 10 '22 23:10 tie

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Dec 10 '22 12:12 github-actions[bot]

Yes. It's still relevant. As @Teutates mentioned above: Bumping @DiegoRBaquero

fishcharlie avatar Dec 10 '22 15:12 fishcharlie

why this wasn't merged since the Autumn?

ivan-zakharchuk avatar Jan 06 '23 20:01 ivan-zakharchuk

@DiegoRBaquero latest merge conflicts removed.

Teutates avatar Feb 14 '23 00:02 Teutates

@DiegoRBaquero this PR has been open for over a year now. Any status updates?

fishcharlie avatar Apr 19 '23 01:04 fishcharlie

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Jun 18 '23 12:06 github-actions[bot]

Yes, this is still relevant. cc @DiegoRBaquero

tie avatar Jun 20 '23 09:06 tie

I'm considering this project is no longer relevant to webtorrent, need to manually update a lot of dependencies plus webtorrent 2.x doesn't work with this client. apart from electron that is very Old

farribeiro avatar Jun 20 '23 12:06 farribeiro

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Aug 20 '23 12:08 github-actions[bot]

Really disappointing that this was closed. @DiegoRBaquero can we get this reopened and merged?

fishcharlie avatar Oct 29 '23 20:10 fishcharlie