webtorrent-desktop icon indicating copy to clipboard operation
webtorrent-desktop copied to clipboard

Compact view for torrent list

Open fknop opened this issue 5 years ago • 12 comments

Hi,

I implemented this small feature for a compacted list of torrents (reduce ~by half the space needed for one item in the list) via a button icon in the header.

I know this might not be a feature necessary to the core application so I'm adding this here and leaving it to discussion!

Tests / formatting may fail for now, I did not check those yet.

fknop avatar Dec 10 '18 19:12 fknop

Can you post before & after screenshots?

dsernst avatar Apr 10 '19 10:04 dsernst

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 09 '19 11:07 stale[bot]

Ping – can someone post screenshots of this?

In general, I'm against adding options for stuff like this. If the compact view is "better" then we should just change to using the compact view for everyone. In general, I agree that WebTorrent current takes up a bit too much space for each torrent list item, so this is probably a good PR to merge, minus the configuration button.

feross avatar Jul 10 '19 16:07 feross

Before and after:

wt_compare_compact

alxhotel avatar Jul 10 '19 17:07 alxhotel

@alxhotel Thanks for posting that. I like the general idea.

Issues:

  • The buttons on the right side or not properly vertically centered.
  • Does the torrent meta-info show up in two lines when the torrent is expanded? Would be more readable than keeping it on one line, in that situation.

feross avatar Jul 10 '19 18:07 feross

I've managed to fix the vertical alignment locally, I think it should be well aligned now.

image

Right now the metadata is kept on one line when the torrent is expanded. I can try to fix this.

fknop avatar Jul 11 '19 12:07 fknop

The behaviour is now the same as before when the torrent is expanded.

fknop avatar Jul 11 '19 13:07 fknop

@fknop Thanks for making those changes. It appears that there is a merge conflict. Can you try to resolve that?

feross avatar Jul 11 '19 20:07 feross

It should be working now. The app still has the two options, if you want to keep only one view I can probably remove the old one as well. Or maybe adding a preference would be better than having a button on the main view?

fknop avatar Jul 11 '19 21:07 fknop

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Jul 24 '21 12:07 github-actions[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Sep 23 '21 12:09 github-actions[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Dec 18 '21 12:12 github-actions[bot]