webtorrent-desktop icon indicating copy to clipboard operation
webtorrent-desktop copied to clipboard

Add option to changue subtitle size

Open limewire opened this issue 7 years ago • 6 comments

I think i should have an option to change the subtitle font size in the "Playback" menu. Looks very small in TV.

limewire avatar Feb 27 '17 10:02 limewire

You can change the font size by styling the subtitle shadow dom with this code:

video::-webkit-media-text-track-display {
  font-size: 50px;
}

I can do a PR if this ideia fits on the project:

  • 2 buttons (plus/minus) controls the style tag with the code above by adding/subtracting 10px on the font-size.

brunoti avatar Jun 14 '17 03:06 brunoti

What do you think about add this option as part of the window application, like subtitle > increment/decrement size?

Kikobeats avatar Jan 19 '18 20:01 Kikobeats

Initially, I think it would be easiest to add this to the Preferences page rather than the menu bar. We need to refactor the way that the Preferences page saves data before we add a menu bar option that causes changes to the persisted preferences, IMO.

I'm +1 for this change, but I'd prefer if one of the other core contributors who's more passionate about this feature volunteered to shepherd it through the PR process, i.e. to test and be the primary point of contact to provide feedback.

feross avatar May 23 '18 10:05 feross

Hey, was this implemented?

mgonto avatar Aug 12 '18 04:08 mgonto

You can change the font size by styling the subtitle shadow dom with this code:

video::-webkit-media-text-track-display {
  font-size: 50px;
}

I can do a PR if this ideia fits on the project:

  • 2 buttons (plus/minus) controls the style tag with the code above by adding/subtracting 10px on the font-size.

How can I do that?

TinoCle avatar Oct 16 '18 00:10 TinoCle

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

github-actions[bot] avatar Oct 01 '22 12:10 github-actions[bot]