parse-torrent icon indicating copy to clipboard operation
parse-torrent copied to clipboard

feat: BitTorrent v2 Support

Open leoherzog opened this issue 3 years ago • 3 comments

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [X] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) Added support for decoding and encoding of infoHashV2 key for BitTorrent v2 Support.

Which issue (if any) does this pull request address? webtorrent/parse-torrent#88

Is there anything you'd like reviewers to focus on? I need a hand updating the tests. I'm not familiar with tape, and I suspect that there are at least a couple of assumptions made in testing that each Torrent object should always must have an infoHash key. The new assumption is a valid object can have an infoHash key, or an infoHashV2 key, or both.

leoherzog avatar May 12 '21 18:05 leoherzog

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] avatar May 12 '21 18:05 welcome[bot]

The assumption is valid, it should have either v1 or v2, or both.

DiegoRBaquero avatar May 13 '21 13:05 DiegoRBaquero

Hey reviewers. What's left to be done to advance this PR?

@feross @DiegoRBaquero

leoherzog avatar Jul 25 '22 19:07 leoherzog