websvn icon indicating copy to clipboard operation
websvn copied to clipboard

"Syntax error in revision argument" when accessing deleted file

Open danielmarschall opened this issue 2 years ago • 2 comments

I noticed that in my php_error.log there are a lot of error messages:

[30-Sep-2023 22:59:35 europe/berlin] Fehler beim Ausführen des Befehls: /usr/bin/svn --non-interactive --config-dir /tmp/websvn log --xml --quiet --limit 2 -r -1:1 'file:///daten/subversion/distributed/ViaThinkSoft%20Distributed/src/de/viathinksoft/distributed/apps/immortal/iterator/marschall/MarschallSectionIterator.java@HEAD'
[30-Sep-2023 22:59:35 europe/berlin] No output on STDOUT.E205000: Syntax error in revision argument '-1:1'

The URL which was accessed and caused the error is this:

https://......./websvn/filedetails.php?path=%2FViaThinkSoft%20Distributed%2Fsrc%2Fde%2Fviathinksoft%2Fdistributed%2Fapps%2Fimmortal%2Fiterator%2Fmarschall%2FMarschallSectionIterator.java&repname=distributed&rev=-1

The directory `.../src/de/viathinksoft/distributed/..." was deleted some time ago.

The GUI correctly shows "404". However, the php_error.log still contains the output due to a failed internal shell access.

I am not sure why this URL was accessed at all. It could be a search engine which tries to open an old URL. Or is it possible that some parts of the WebSVN links to this file, e.g. if you look in old Logs/Diffs?

danielmarschall avatar Sep 30 '23 21:09 danielmarschall

Well, yes, -1 should not be passed at all. I'll try to look at it next month.

michael-o avatar Sep 30 '23 21:09 michael-o

I cannot see any spot in the code where the -1 is set. I was able to force the issue by supplying -1 only manually. It'd be could if could try to reproduce it.

michael-o avatar Nov 06 '23 11:11 michael-o