Erik Westra

Results 51 comments of Erik Westra

> As an inspiration maybe take a look at what prow's approver plugin is doing? That's the lgtm command that everyone in the Kubernetes ecosystem is using anyways. I'll have...

> As an inspiration maybe take a look at what prow's approver plugin is doing? That's the lgtm command that everyone in the Kubernetes ecosystem is using anyways. So a...

@Skarlso just to put out the options I see for solving the third point: Option A: Go with the current system, meaning anyone with any of the needed roles can...

> Hm, I lean towards an easier solution. One that is less complex to maintain. I guess the reviewer would have to keep in mind that if there is code...

> Sounds good! okay so just to confirm I'll add the following changes. - [x] Remove lgtm label if PR is updated - [x] Warn maintainers (in the lgtm message)...

@Skarlso I've implemented the remainder of the changes and cleaned up the code a bit. The description is now up to date, two outstanding questions for reviewers however maybe they...

I removed the token generation from the lgtm removal step as it doesn't need it for simple label checking and deleting steps. That should make the CI pass now.

> Generally looks okay. I'm a bit concerned about maintainability at this point. Honestly I think it would be better to write our own act8n in go and use GitHub's...

> @webstradev this is the thing I wrote that can be run on a trigger: https://github.com/Skarlso/caretaker Looks nice! I think it's definetly still worth considering implementing our own action as...

just a reminder, when this is merged, the actual label still needs to be created if you want to name it anything else than lgtm, then you can change the...