ws icon indicating copy to clipboard operation
ws copied to clipboard

expose close callback

Open coolaj86 opened this issue 8 years ago • 5 comments

You have a .close(code, data) method here: https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L100

But you don't expose the callback here: https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L121

coolaj86 avatar Nov 09 '15 20:11 coolaj86

I patched it such that if the callback is supplied it uses the callback for error instead of emitting.

https://github.com/websockets/ws/pull/614

coolaj86 avatar Nov 09 '15 20:11 coolaj86

Your pull request is failing the code checks. You'll want to update it to keep from failing. It will hopefully get merged after that?

Eeems avatar Nov 26 '15 23:11 Eeems

Screenshot_3 It`s my problem

nikelborm avatar Jan 11 '20 19:01 nikelborm