FirebaseRTC
FirebaseRTC copied to clipboard
webrtc
What kind of weed was the author of this lab smoking??
Jeez, where to start. The easy thing is fixing the obvious syntax error of -> to =>. But the walk-through and the code are totally out of sync. The create a room code is easy enough to put where the comment says, though again, out of sync with the directions. Then it starts to get confusing cause the walk-through talks about adding the code to join a room but doesn't specify where to put it. Adding it immediately after the "create" code ain't working. Another error that comes up is the fact the roomSnapshoot variable is being used but not defined. This whole thing needs to be re-looked at and the author needs some lessons in how to properly teach. Putting the final code somewhere in this repo would be nice.
The missing comment has been added to app.js at the appropriate place.
Sorry about the mistake of function arrow in the codelab instructions. We'll update that ASAP as well.
What about the other confusing comments like:
// Listening for remote session description below
// Listening for remote session description above
// Listen for remote ICE candidates below
// Listen for remote ICE candidates above
// Code for creating SDP answer below
// Code for creating SDP answer above
The Walkthrough (https://webrtc.org/getting-started/firebase-rtc-codelab) has not mentioned that.
Not to mention the fact that the addition of the code that starts with "const offer = roomSnapshoot..." is very unclear about where to put it. It's in the topic of Join Room, but no clear indication of where it goes. If it's simply added to Create Room, the "offer" var has to be renamed and the roomSnapshot is null, causing an error. This kind of stuff really is rendering this entire walkthrough pretty useless. I'm not a rookie in the business by no means but I am very new to this topic so walkthroughs are incredibly important.
@miguelcastro67 I hear your concerns, but I don't agree with your opinion that the codelab is useless. There are room for improvements, and we'll continue to work on this.
I know I came in strong but the fact is that there are not nearly enough step by step directions for someone coming into this tech fresh to even get it working. Where to put that piece of code that invalidly resets that constant and references a null object is an example. I had to make an educated guess on that and I’m still unclear about if I got it right. Until the lab actually works by simply following the steps given with no guesses on the dev’s part, it’s simply incomplete and non functioning. Look I know these things are not merely no brainers to put together. Trust me, I wrote online courseware. But it just seems as if this was scotch-taped together without a lot of effort. All this being said, please let me know if I can be of help. If you think it would help, I’d be happy to arrange everything I think is wrong. I think this tech has a lot promise and should be looked at closely by more people. Miguel
Sent from my phone Please excuse any boneheaded errors or random curses.
Miguel A. Castro President & Principal Consultant Melvicorp LLC
Twitter: @miguelcastro67
Also a Pluralsight author!
On Feb 25, 2020, at 2:57 AM, Erik Hellman [email protected] wrote:
@miguelcastro67 I hear your concerns, but I don't agree with your opinion that the codelab is useless. There are room for improvements, and we'll continue to work on this.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
Completely agree with @miguelcastro67 ! Especially, since this is linked on webrtc.org as "Get Started" guide - assuming no prior knowledge, nearly no beginner would ever get this running.
Erik, do you have any idea when you'll be posting a working Code Lab? I'm really not going to be able to recommend this technology to my client if I can't educate myself on it; and I can't with the current state of the Code Lab. In all honesty, you need to go through it step by step and I think you'll notice where the lab instructions and the starter code do not sync. Lot's of confusing comments, comments for which you have no implementation, and implementation for which you have no comments. It truly is not workable at all in its current state. Thanks.
The best part is where it says "we will secure the database later" and I am still waiting for that, also what about the part of deploying and hosting from firebase ?
Well I certainly didn’t mean to start a shitstorm but I think it’s easy to see that there are more than just myself that would like to get this usable. It’s a pretty new tech even for seasoned devs. And it’s certainly not intuitive enough that it can just be figured out. I think a good and working walkthrough and sample project is crucial. What do you say, Erik?
I'm not actively involved in this project myself anymore, so I don't have much time to spend on this. The owners of the project are aware of this and hopefully will address that as soon as possible.
The paste in code from the codelab is also filled with the same "->" typo
And the comments are seriously still messed up
This codelab is indeed beneficial but is still a waste of time if the product doesn't work
Please fix this!!!
Can anyone please help me out? Where do we even call the collectICECandidates function mentioned in the last step? Also what do we send as the local and remote parameters to the function?
Here is the code that works! https://pastebin.com/rnGGF9rS
Edit: This only fixes the UI not the stream
You know, I don't really know where these functions are being called Also, this works great on my laptop, but when I connect with another device in the LAN then the site can't access the webcam of that device. So I haven't been able to test the actual video chat just the UI....
As for the latter part I had to deploy for the scripts to work on other devices just run "firebase deploy"
I think there is an error however with how the collectIceCandidates function is implemented as @py-zoid mentioned. I enter in the same room ID but do not see the other devices' stream...
Have you tried looking here? I am trying to just go through their docs and figure it out myself. As it's been over a month since any of the authors/owners made any changes to this repo https://webrtc.org/getting-started/peer-connections
Ok so localName and remoteName are just strings that reference the collection in the room documents, for some reason there are no collections in those documents. I tried "offer" and "answer" and even offer.spd and answer.spd
I am running the collectIceCandidates function at the end of the joinRoomById function
There are no errors. However, I don't see the stream of other device on my laptop screen and vice versa. There are no errors but no actual connection either. The Friebase database shows that an answer and offer have been sent and recieved. Its a whole mess :(
@py-zoid I noticed you deleted a few of your comments... did you fix the issue?
@cybertheory I don't think what I mentioned before was the issue. If you just want the solution to this codelab, it's under the solution thread of this repo.
Hello, so I was also trying the codelab. I found it absolutely impossible to use.
I was wondering if someone found the good code? I have checked in the sample but it looks like it's not present.
well for me the solution branch also not working, when ever i am creating a room it works fine but when i try to join this room by using its id on another window it shows that roomSnapshot does not exists
I'm also facing a similar issue than @Umair115, in the sense that I'm able to create a room and join it once. Attempting to join again after reloading the page or from a different browser/device will perform a PeerConnection creation but not change the status to connected, therefore not displaying any streamed video.
I just resolved that error, now this thing is working fine on local means if u connect it on another browser window it is displaying the remote video On Apr 15, 2020 7:09 PM, "Adrian Lopez" [email protected] wrote:
I'm also facing a similar issue than @Umair115 https://github.com/Umair115, in the sense that I'm able to create a room and join it once. Attempting to join again after reloading the page or from a different browser/device will perform a PeerConnection creation but not change the status to connected, therefore not displaying any streamed video.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/webrtc/FirebaseRTC/issues/3#issuecomment-614062578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ7BIT3QNBHAEFZNVA4XMBTRMW5X5ANCNFSM4KYT6D3Q .
@AdrianLopezMuller I think this sample code is a one use only for each room. The room gets deleted once someone hangs up so you can't rejoin it through a refresh or from another device.
well you are right also this code as some issues in creating a connection, sometime it is connected very easily sometime it is not, i already tried removing icecandidate numbers ,it is still not working i was thinking to use a turn server now
On Thu, Apr 23, 2020 at 7:45 AM Michael Powers [email protected] wrote:
@AdrianLopezMuller https://github.com/AdrianLopezMuller I think this sample code is a one use only for each room. The room gets deleted once someone hangs up so you can't rejoin it through a refresh or from another device.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/webrtc/FirebaseRTC/issues/3#issuecomment-618144389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ7BIT37ECNYXO4VQ5436UTRN6TVHANCNFSM4KYT6D3Q .
@powerspowers Thanks for the heads up! Do you know of any other demo where multiple calls can be placed at the same time and reconnecting to the same room is possible? It doesn't need to use firebase in any case.