webrtc
webrtc copied to clipboard
[interceptor] control max packet age for NACK responses
TODO:
- [x] Tests
Codecov Report
Base: 59.87% // Head: 59.87% // No change to project coverage :thumbsup:
Coverage data is based on head (
3e47da6) compared to base (3e47da6). Patch has no changes to coverable lines.
:exclamation: Current head 3e47da6 differs from pull request most recent head 5302015. Consider uploading reports for the commit 5302015 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 59.87% 59.87%
=======================================
Files 503 503
Lines 47644 47644
Branches 12357 12357
=======================================
Hits 28528 28528
Misses 9889 9889
Partials 9227 9227
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@k0nserv any plan on merging this any time soon? I think we're also hitting the edge case of retransmissions aggravating the problem
I also wonder how receivers handle the case where certain nacks are ignored. E.g. I've seen Chrome sending the same nack over and over.
@k0nserv anything left to do here except (a) rebase (b) fix conflicts ? thanks 🙏
I don't believe so