webrtc icon indicating copy to clipboard operation
webrtc copied to clipboard

Support completely unreliable datachannels

Open connorcarpenter opened this issue 2 years ago • 1 comments

It appears that DataChannel parameters: id maxRetransmits & maxPacketLifetime were not translated completely from https://github.com/pion/webrtc/blob/master/datachannel.go#L26

These parameters are able to have a value of nil in Pion, which allows for setup of datachannels which are completely unordered & unreliable. There's a big difference between an id or maxRetransmits of nil vs 0, which webrtc-rs currently conflates.

This will allow interop with https://github.com/triplehex/webrtc-unreliable .

This PR requires the usage of the following PRs to function correctly: https://github.com/webrtc-rs/sctp/pull/10 https://github.com/webrtc-rs/data/pull/5

connorcarpenter avatar Apr 30 '22 23:04 connorcarpenter

@connorcarpenter, similar issue in https://github.com/webrtc-rs/data/pull/5.

rainliu avatar May 06 '22 00:05 rainliu

Sorry we never got this merged @connorcarpenter. If you wanna re-open https://github.com/webrtc-rs/data/pull/5 and rebase this we can look at it again

k0nserv avatar Oct 06 '22 08:10 k0nserv