synthwave-x-fluoromachine icon indicating copy to clipboard operation
synthwave-x-fluoromachine copied to clipboard

Differentiate objects and object properties

Open wKovacs64 opened this issue 5 years ago • 5 comments

Intent

I noticed objects were pretty visually homogeneous and coming from other themes that target variables and properties separately from parent objects, etc. I felt they should be easier to digest at a glance. I tried to replicate that here. I chose one color that you already use and another from FluoroMachine, but feel free to adjust them as needed if you have any interest in this change. I used some pretty general scopes and made up names for the rules - feel free to change them or propose others of course. Lastly, I didn't add glow anywhere, not sure if that's needed or not.

Result

Before:

image

After:

image

Disclaimer

I don't know anything about making themes, and I'm colorblind, so take this PR with a grain of salt. 🙂

Thanks for reviewing.

wKovacs64 avatar May 15 '20 20:05 wKovacs64

Love this one! But maybe the purple font is a bit too dark with that background?

jsbase avatar Jul 07 '20 12:07 jsbase

Possibly. It looks OK to me, but again - I'm colorblind - so I'm not the best judge. Happy to change it if you have an alternate suggestion! Just needs to stand out from adjacent text.

wKovacs64 avatar Jul 07 '20 14:07 wKovacs64

Looks great to me!

Rylon avatar Jul 07 '20 19:07 Rylon

Hey there! Sorry for the delay on reviewing this. Looks great, I plan on merging it into master this weekend.

webrender avatar Aug 20 '20 16:08 webrender

Still interested in this? 😅

wKovacs64 avatar Jul 18 '22 22:07 wKovacs64