warcio
warcio copied to clipboard
webrecorder
Plans for adding type annotations?
Hi all,
Are type annotations on the roadmap at all? Would you take PRs for it? If so, would you prefer the comment-based, Python2 compatible annotation scheme, or the syntax introduced by PEP 526(which means dropping support for anything older than Py3.6)?
PS: It's always a great feeling when you know there's a (well maintained) Python library out there tailored exactly to your current needs. Thank you!
Got it @wumpus !
My other question is: do you plan on adding (or accepting PRs that add) type annotations the code base? One of the following methods can accomplish this(even in python versions older than 3.6)
Can you produce a short example as a PR? Then we can see if (1) if it can pass our CI in all python versions and (2) how pretty it looks.
My intent with this question was to see if there's a plan already for type annotations, since I usually end up annotating the libraries I use (if they're small enough), and I wanted to follow any guidelines that were already in place so I can contribute the annotations back.
If I end up using the library, and writing up type annotations as a result, I'll be sure to create a PR and ping you here.
I don't think there is any plan, and I'd love to have one. If we can keep our current range of pythons and have annotations, that would be awesome.
There is no plan and I don't have time to focus on that, but happy to review a PR. Looking at it briefly, the type comments seems to be the best option, and comparable to the type annotations. For now, it would not be worth it to drop older versions to support annotations.
