browsertrix
browsertrix copied to clipboard
[Bug]: Auto-loading replay with single seed URLs that use basic auth doesn't work
Browsertrix Version
v1.10.2-dc9069d
What did you expect to happen? What happened instead?
As of https://github.com/webrecorder/browsertrix/commit/06b512bb8424a481cf72476cc571f918a693116a, the frontend will automagically give ReplayWeb.page the seed URL as a starting URL if there is only one seed URL in the crawl workflow. This is mostly good and gets users to where they want to go faster, but in the case of basic auth, we strip the credentials before writing the URLs which means that the page http://username:[email protected]
isn't present in the archive (and should instead just return http://example.com
as the url for ReplayWeb.page to load).
Reproduction instructions
- Crawl a webpage with basic auth.
- Once the crawl is finished, load the replay tab, note that it should not load properly.
- Strip the credentials from the URL and attempt to load that page from the archive, note that it should load properly.
Additional details
Originally reported by @edsu, thanks!