[Bug]: Max Depth is not listed in the list of workflow settings

[tuehlarsen]

Browsertrix Version

v1.9.4-08ee857

What did you expect to happen? What happened instead?

When you list the workflowsettings e.g for berlingske med all cookies and disabled shields and click on workflow settings the Max Depth is not listed even though it is set 0

Reproduction instructions

se above

Screenshots / Video

No response

Environment

No response

Additional details

No response

[Shrinks99]

Can reproduce, thanks for filing!

[Shrinks99]

Took a brief look at this, looks like this.renderConfirmUrlListSettings, isn't getting triggered in config-details.ts which would render the missing settings(more than just max depth!).

console.log(this.crawlConfig?.jobType) returns undefined.

Have started a branch for this (frontend-config-details-updates) and a few other labeling and re-ordering improvements to match the workflow selector.

[SuaYoo]

Took a brief look at this, looks like this.renderConfirmUrlListSettings, isn't getting triggered in config-details.ts which would render the missing settings(more than just max depth!).

"Max Depth" is hidden if the scope type isn't the following: "host", "domain", "custom", "any". The linked workflow has a scope of prefix. If this is the correct behavior (cc @ikreymer) we may need to hide the "Max Depth input" along with the setting.

[ikreymer]

"Max Depth" is hidden if the scope type isn't the following: "host", "domain", "custom", "any". The linked workflow has a scope of prefix. If this is the correct behavior (cc @ikreymer) we may need to hide the "Max Depth input" along with the setting.

Hm, it should be included for prefix too, that may have been an oversight - since prefix could be the root of a hostname and then its not any different than host. We still allow the setting on the backend for prefix as well