knip icon indicating copy to clipboard operation
knip copied to clipboard

🐛 False Unused devDependencies report for biome extensions

Open ianzone opened this issue 11 months ago • 4 comments

Prerequisites

Reproduction url

https://github.com/ianzone/react-storybook

Reproduction access

  • [X] I've made sure the reproduction is publicly accessible

Description of the issue

knip reports

Unused devDependencies (2)
@storybook/blocks  package.json
biome-extends      package.json

While biome-extends is consumed by biome.json.

ianzone avatar Jan 04 '25 17:01 ianzone

Thanks for the report, Yiheng! There's no Biome plugin yet, so this makes sense.

Would you like to add a plugin and submit a pull request?

webpro avatar Jan 04 '25 17:01 webpro

Ok, I'll write it.

ianzone avatar Jan 04 '25 18:01 ianzone

@ianzone if you don't get a chance to implement it, please post it here :)

insulineru avatar Jan 14 '25 13:01 insulineru

@ianzone if you don't get a chance to implement it, please post it here *)

Hi, I'm getting busy this month. Many thanks if you're willing to take it

ianzone avatar Jan 14 '25 14:01 ianzone

@ianzone I'm trying to reproduce your report. With your repo, shouldn't report be

Unused devDependencies (2)
@storybook/blocks  package.json
@biomejs/biome      package.json

instead of biome-extends ?

tidefield avatar Jun 01 '25 07:06 tidefield

@ianzone I think I was able to find the culprit commit https://github.com/ianzone/react-storybook/commit/cb3450a581a3a042ec8a24d92592d66809835ac2#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bb. My plugin implementation will support this use case.

tidefield avatar Jun 01 '25 18:06 tidefield