knip icon indicating copy to clipboard operation
knip copied to clipboard

🐛 `vitest.workspace.mts` Not Dectected by Vitest Plugin

Open joealden opened this issue 1 year ago • 1 comments

Prerequisites

Reproduction url

N/A

Reproduction access

  • [X] I've made sure the reproduction is publicly accessible

Description of the issue

As shown in https://knip.dev/reference/plugins/vitest, vitest.workspace.ts|js|json is picked up, but mjs|cjs|mts|cts extensions are not. I know for sure that vitest.workspace.mts is valid to Vitest, so should we just match the extensions we are looking for for the normal Vitest configs?

joealden avatar Sep 18 '24 13:09 joealden

Yes, that makes sense. Any chance you would be willing to submit a PR to fix that up?

webpro avatar Sep 18 '24 13:09 webpro

@webpro sure! See https://github.com/webpro-nl/knip/pull/785.

joealden avatar Sep 19 '24 10:09 joealden