laravel-countries icon indicating copy to clipboard operation
laravel-countries copied to clipboard

Added continents

Open lsimeonov opened this issue 7 years ago • 5 comments

I added continents to countries.

Source is https://restcountries.eu/

lsimeonov avatar Jul 13 '16 13:07 lsimeonov

Is it cleaner that you insert the continent with a relation. to avoid data duplication?

Tjoosten avatar Aug 19 '16 15:08 Tjoosten

Could you update your PR so it can merge again, since it has conflicts now?

webpatser avatar Aug 29 '16 11:08 webpatser

@webpatser Will do as soon as I have some time on my hands. There are some changes in the countries.json file so I'll need some time to review the merge by hand.

lsimeonov avatar Aug 29 '16 12:08 lsimeonov

@webpatser PR updated

lsimeonov avatar Sep 07 '16 12:09 lsimeonov

With the changes for Laravel 5.5 support, your PR is conflicting. Can review your changes again. Then we can merge your changes.

webpatser avatar Oct 15 '17 11:10 webpatser