webpack icon indicating copy to clipboard operation
webpack copied to clipboard

Remove redundant semicolons after onScriptComplete function close: #16346

Open ahaoboy opened this issue 3 years ago • 5 comments

What kind of change does this PR introduce? Remove redundant semicolons after onScriptComplete function related to https://github.com/webpack/webpack/issues/16346

Did you add tests for your changes? no

Does this PR introduce a breaking change? no

What needs to be documented once your changes are merged? no

ahaoboy avatar Oct 08 '22 04:10 ahaoboy

For maintainers only:

  • [ ] This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • [ ] This needs to be backported to webpack 4 (issue will be created when merged)

webpack-bot avatar Oct 08 '22 04:10 webpack-bot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ahaoboy / name: 阿豪 (f122c858a9aadcbdc20ddd4e0a7f48a88aecef49)

Hi @ahaoboy.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own main branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

webpack-bot avatar Oct 09 '22 04:10 webpack-bot

@alexander-akait @rishabh3112 PTAL, ready to merge~

ahaoboy avatar Nov 18 '22 08:11 ahaoboy

/cc @TheLarkInn

alexander-akait avatar Feb 10 '23 19:02 alexander-akait

Thank you for the contribution 🚀 🙏

TheLarkInn avatar Mar 13 '23 15:03 TheLarkInn