webpack.js.org icon indicating copy to clipboard operation
webpack.js.org copied to clipboard

Published 20 hours ago • verified publisher icon webpack

Responsive sponsor ad

Open JamesSwinton opened this issue 10 months ago • 7 comments

I have updated the AG Grid sponsor section so that it appears on small & mobile devices.

JamesSwinton avatar Apr 11 '24 11:04 JamesSwinton

@JamesSwinton is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 11 '24 11:04 vercel[bot]

@JamesSwinton Can you add screenshots before/after, thank you

alexander-akait avatar Apr 11 '24 11:04 alexander-akait

Hey @alexander-akait, sure, no problem:

Before: Before

After: After

JamesSwinton avatar Apr 11 '24 13:04 JamesSwinton

Can you rebase?

alexander-akait avatar Apr 11 '24 13:04 alexander-akait

Should be ready to merge now, thanks

JamesSwinton avatar Apr 11 '24 14:04 JamesSwinton

Not sure we want to show ads on top of small screens, it would be terrible UX IMO.

chenxsan avatar May 27 '24 14:05 chenxsan

I agree, showing add on top would shift the content below leading to a degraded UX. Maybe we can do something similar to ESLint, it moves the ad to the footer on small screens.

Screenshot 2024-06-04 at 6 05 52 AM

snitin315 avatar Jun 04 '24 00:06 snitin315