webpack.js.org icon indicating copy to clipboard operation
webpack.js.org copied to clipboard

404 page is Missing

Open duhbhavesh opened this issue 4 years ago • 7 comments

Feature Request

404 page doesn't have header and footer for navigating through website & doesn't have link to homepage.

webpack

duhbhavesh avatar Jan 03 '21 09:01 duhbhavesh

@duhbhavesh Thanks for the issue.

Actually, we do have a custom 404 page but it doesn't work on gh-pages somehow for the reasons explained here - https://stackoverflow.com/questions/58228017/react-router-v4-cant-load-page-on-github-pages

I'm looking into it if I can find a potential solution.

Screenshot at 2021-01-04 07-47-58

snitin315 avatar Jan 04 '21 02:01 snitin315

I found either using HashRouter instead of BrowserRouter or adding a custom 404.html at root is a workaround for this over the whole internet.

Using HashRouter will change URLs to something like https://webpack.js.org/#/api which I don't think is a good idea.

Or we can use vercel for deployment (given that we already have a PRO account).

snitin315 avatar Jan 04 '21 04:01 snitin315

Okay! 😅

duhbhavesh avatar Jan 04 '21 14:01 duhbhavesh

@snitin315 Hey. My question is not related to this topic, but your screenshot above shows it perfectly:

Screenshot at 2021-01-04 07-47-58

Fonts for headings are wrong here, and this occurs across the whole website Can we have some fix for this and are you aware of this problem?

tjbulick avatar Jan 11 '21 21:01 tjbulick

@snitin315 Hey. My question is not related to this topic, but your screenshot above shows it perfectly:

Screenshot at 2021-01-04 07-47-58

Fonts for headings are wrong here, and this occurs across the whole website Can we have some fix for this and are you aware of this problem?

I'm aware of it because I did it on purpose :) I'm wondering why would you think the serif font for headings is wrong? And what's your proposal, Pros and Cons?

I made that change because when headings share the sans-serif font family with body texts, there’s not enough contrast between them. I know many websites use just Sans-serif for both headings and body text, e.g., react, next, etc., but that doesn’t make it a rule we must follow.

Here's a comparison between serif for headings and sans-serif for headings:

comparison

Anyway, this is another topic, if you really think it's an issue, please create a new one so we can discuss.

chenxsan avatar Jan 11 '21 23:01 chenxsan

Regarding the 404 issue. This site is hosted on github pages, so it's possible to create a 404 html file https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/creating-a-custom-404-page-for-your-github-pages-site. I'll see how we can add one under this single page application.

chenxsan avatar Jan 12 '21 05:01 chenxsan

Generally it's not possible with the current tech stacks, we can only count on github to add the support for single page application. See https://github.com/isaacs/github/issues/408

chenxsan avatar Jul 04 '21 02:07 chenxsan