webpack.js.org
webpack.js.org copied to clipboard
webpack
docs: add namedmodulesplugin description (#2547)
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Hey @prondubuisi ! Nice job, we're almost set!
For this PR to work, you will need to create a page for the link you just added. I suggest you looking at where the other plugins are located and create a markdown file there with the documentation for the plugin that you just added. That will fix the issue!
@montogeek
Okay. I was thinking there was zero configuration for this.
On Tue, Dec 11, 2018, 8:14 AM Even Stensberg <[email protected] wrote:
@evenstensberg requested changes on this pull request.
I think maybe you should come up eith examples as well as how it would look like using a configuration file. Good job so far! 🤘🏽
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/webpack/webpack.js.org/pull/2708#pullrequestreview-183534845, or mute the thread https://github.com/notifications/unsubscribe-auth/AVRz-Iux3sBnWX_jJQoj19vvpGKxL2GQks5u31tcgaJpZM4ZJz-B .
Did you try to use the plugin and see how it works before documenting it @prondubuisi ?
@prondubuisi you will need to use the plugin and write the documentation a bit more detailed. As @EugeneHlushko says, there is some key things missing here