fix: #1719

[orange4glace]

• [x] This is a bugfix
• [x] This is a feature
• [ ] This is a code refactor
• [ ] This is a test update
• [ ] This is a docs update
• [ ] This is a metadata update

fix for #1719

When sending a 'ok' and 'invalid' message, compiler name is passed as a data. compiler name can be defined in config options. If user does not provided it, the script generates a random guid as a compiler name.

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

[codecov[bot]]

Codecov Report

Merging #2017 into master will decrease coverage by 0.69%. The diff coverage is 92.68%.

@@            Coverage Diff            @@
##           master    #2017     +/-   ##
=========================================
- Coverage   92.77%   92.08%   -0.7%     
=========================================
  Files          29       29             
  Lines        1149     1175     +26     
  Branches      327      335      +8     
=========================================
+ Hits         1066     1082     +16     
- Misses         79       88      +9     
- Partials        4        5      +1

Impacted Files	Coverage Δ
lib/utils/updateCompiler.js	100% <100%> (ø)	:arrow_up:
lib/utils/addEntries.js	85.18% <100%> (-14.82%)	:arrow_down:
lib/Server.js	92.73% <100%> (+0.22%)	:arrow_up:
client-src/default/index.js	90.38% <81.25%> (-1.84%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 303f4e9...5a6bd69. Read the comment docs.

[codecov[bot]]

Codecov Report

Merging #2017 into master will increase coverage by 0.2%. The diff coverage is 81.18%.

@@            Coverage Diff            @@
##           master    #2017     +/-   ##
=========================================
+ Coverage   92.77%   92.97%   +0.2%     
=========================================
  Files          29       30      +1     
  Lines        1149     1182     +33     
  Branches      327      332      +5     
=========================================
+ Hits         1066     1099     +33     
  Misses         79       79             
  Partials        4        4

Impacted Files	Coverage Δ
lib/utils/guid.js	100% <100%> (ø)
lib/utils/updateCompiler.js	100% <100%> (ø)	:arrow_up:
lib/servers/BaseServer.js	100% <100%> (ø)	:arrow_up:
lib/servers/SockJSServer.js	96.29% <100%> (ø)	:arrow_up:
lib/Server.js	92.76% <75.32%> (+0.25%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f611304...490c148. Read the comment docs.

[orange4glace]

Agreed. Rather than modifying both server and client code, distinguishing websocket messaging like using channel by modifying only server code (and minimum client code modification as possible) seems to be a better implementation. I was kind of in a hurry so the implementation is actually dirty. I'll improve it with further commits :)

[orange4glace]

The new commit remains client code unchanged (so the code is completely same with the upstream master code) and only server code is changed. Please see the commit (even it contains tiny errors and corrected by the next commits)

I am trying to write and run tests, but running test keeps failing. It seems like Windows related error. I'm using VSCode in Windows 10 and if any code change happens with Windows environment editor, ESLint test goes fail, with unknown error.

Could you check if error happens on test with my repository source?

[alexander-akait]

What is error(s) you got?

[orange4glace]

Actually the error is much same with what Azure pipeline did. It seems error happens on Lint:prettier

Error log is here, and the complete log file is here

[alexander-akait]

You can run tests using npm run test:only and avoid fixing linting issue right now, we can do this at last step of PR