webpack-dev-middleware
webpack-dev-middleware copied to clipboard
feat: Add historyApiFallback option
This PR contains a:
- [ ] bugfix
- [x] new feature
- [ ] code refactor
- [ ] test update
- [ ] typo fix
- [ ] metadata update
Motivation / Use-Case
Add useful option historyApiFallback. Ability to use React Router5 like as webpackDevServer https://webpack.js.org/configuration/dev-server/#devserverhistoryapifallback
Breaking Changes
Additional Info
I add new branch and write right commit message
original pull request #922
Codecov Report
Patch coverage: 100.00
% and project coverage change: -2.51
:warning:
Comparison is base (
de760f6
) 97.34% compared to head (bf596f6
) 94.84%.
:exclamation: Current head bf596f6 differs from pull request most recent head 65bb7e2. Consider uploading reports for the commit 65bb7e2 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #930 +/- ##
==========================================
- Coverage 97.34% 94.84% -2.51%
==========================================
Files 9 10 +1
Lines 377 291 -86
Branches 112 103 -9
==========================================
- Hits 367 276 -91
- Misses 9 13 +4
- Partials 1 2 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/utils/getFilenameFromUrl.js | 97.72% <100.00%> (-0.52%) |
:arrow_down: |
... and 10 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I am sorry. I was make commit via vs code.
Don't worry, I will squash them before merge
@hiroppy something wrong?
All fine, I will finish dev server stable release and will improve dev middleware, more caches, features, less build time and other
I still have light feeling that we do something wrong because logic historyApiFallback
is more complex than this, to unstand your can you provide github repo with example of usage this feature, so I can undestand how it can be used, thank you and sorry for delay again