webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard

Published 20 hours ago • verified publisher icon webpack

feat: Interactive Plugin

Open rishabh3112 opened this issue 2 years ago • 4 comments

Different from interactive at #586: This PR just adds support for interactive output mode.

What kind of change does this PR introduce? Feature

Did you add tests for your changes?

If relevant, did you update the documentation? Not applicable

Summary There are two output modes for --watch and webpack serve, standard and interactive. Standard is already supported. This PR aims to implement that.

Does this PR introduce a breaking change? No

Other information /cc @alexander-akait

rishabh3112 avatar May 14 '22 07:05 rishabh3112

Codecov Report

Merging #3243 (e6835e3) into master (748ae9e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3243   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files          23       23           
  Lines        1731     1731           
  Branches      519      519           
=======================================
  Hits         1594     1594           
  Misses        137      137
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 93.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5034913...e6835e3. Read the comment docs.

codecov[bot] avatar May 14 '22 08:05 codecov[bot]

This is just empty code though....

Yeah, I know 😆 . See #1796 closing comment for more info.

rishabh3112 avatar May 16 '22 06:05 rishabh3112

Yes, let's finish it, although perhaps we should first do major release:

  • drop node v12
  • drop webpack-dev-server v3
  • update deps (there is possible without big changes)

alexander-akait avatar May 16 '22 13:05 alexander-akait

Yes, let's finish it, although perhaps we should first do major release:

  • drop node v12
  • drop webpack-dev-server v3
  • update deps (there is possible without big changes)

Okay, will do. Should node version 10 be removed too?

rishabh3112 avatar May 17 '22 05:05 rishabh3112

Sorry for losing your time, but let's close it due https://github.com/webpack/webpack-cli/issues/586#issuecomment-1528836367

In the future, we should study better and deeper the issues of what we should develop or not, in order not to get into such situations, once again I deeply apologize

alexander-akait avatar Apr 29 '23 17:04 alexander-akait