webpack-cli
webpack-cli copied to clipboard
webpack
fix: add css and style loader to sass/stylus/less template
What kind of change does this PR introduce? Fixes the sass config generation.
Did you add tests for your changes? No.
If relevant, did you update the documentation? No, no change needed.
Summary
Related to #3171
Does this PR introduce a breaking change? No.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: TheRealSyler / name: Leonard Grosoli (b6c3e5258a3f5c28c6f689524dc900d130c6f175, 12dea6df972beaea837f527518a5682c3f723814)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #3172 (a44b7a8) into master (7adaa63) will decrease coverage by
5.81%. The diff coverage is77.77%.
Additional details and impacted files
@@ Coverage Diff @@
## master #3172 +/- ##
==========================================
- Coverage 90.98% 85.17% -5.82%
==========================================
Files 23 23
Lines 1731 1733 +2
Branches 519 519
==========================================
- Hits 1575 1476 -99
- Misses 156 257 +101
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/generators/src/handlers/default.ts | 55.55% <0.00%> (-43.21%) |
:arrow_down: |
| packages/generators/src/handlers/react.ts | 13.63% <0.00%> (ø) |
|
| packages/webpack-cli/src/plugins/CLIPlugin.ts | 98.52% <100.00%> (-1.48%) |
:arrow_down: |
| packages/webpack-cli/src/webpack-cli.ts | 91.50% <100.00%> (-2.45%) |
:arrow_down: |
| packages/generators/src/utils/scaffold-utils.ts | 68.75% <0.00%> (-31.25%) |
:arrow_down: |
| packages/serve/src/index.ts | 61.07% <0.00%> (-20.96%) |
:arrow_down: |
| packages/generators/src/init-generator.ts | 92.50% <0.00%> (-5.00%) |
:arrow_down: |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7adaa63...a44b7a8. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @TheRealSyler.
Just a little hint from a friendly bot about the best practice when submitting pull requests:
Don't submit pull request from your own
masterbranch. It's recommended to create a feature branch for the PR.
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.
@TheRealSyler Thanks for your update.
I labeled the Pull Request so reviewers will review it again.
@rishabh3112 Please review the new changes.
@rishabh3112 well see if it fixes the issue, i saw that one test failed because it ínstalled packages that weren't in the snapshot.
I have increased the time again based on the time i saw in the test, but the limit is over 50min now, which might be bad but im not familiar enough with this project to judge that.
I have increased the time again based on the time i saw in the test, but the limit is over 50min now, which might be bad but im not familiar enough with this project to judge that.
It is bad but we can investigate it later. Feel free to create a issue for it. Thanks.
@alexander-akait i forgot about this, i can take a look at it, next week or maybe the one after that.
@alexander-akait i looked at this again and it seems like the issue itself is already solved, i ran all the tests locally (one test failed but i don't think its relevant to this pr) and used my local version to bootstrap a sass project.
The issue seems to be that the ci fails, the logs of the ci output have already been deleted, you guys need to retrigger the ci to see why it fails, if i remember correctly the windows-latest tests take so long that they get aborted.
@snitin315 i never used rebase before but i think i did it.
edit: i think something went wrong now there are +3,213 −2,520 changes