fix: no serve when dev-server is false
What kind of change does this PR introduce? Fix
Did you add tests for your changes? Yup
If relevant, did you update the documentation? Yes
Summary
No dev server when devServer: false is supplied.
Does this PR introduce a breaking change? Nope
Other information /cc @alexander-akait
Codecov Report
Merging #2947 (c18b084) into master (bd661fb) will increase coverage by
0.02%. The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.02%
==========================================
Files 22 22
Lines 1688 1692 +4
Branches 486 488 +2
==========================================
+ Hits 1534 1538 +4
Misses 154 154
| Files | Coverage Δ | |
|---|---|---|
| packages/serve/src/index.ts | 79.46% <ø> (ø) |
|
| packages/webpack-cli/src/webpack-cli.ts | 92.63% <100.00%> (+0.02%) |
:arrow_up: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update bd661fb...c18b084. Read the comment docs.
@alexander-akait devServer is object in schema, should change/publish that first to support devServer: false.
We should return before using schema
We should return before using schema
We should not read configuration without validating against schema ideally.
We need to revert this, because we should not exit, just run a regular compilation with a warning, I will fix it
Also webpack build with devServer: false should work too without any problems