webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard

fix: no serve when dev-server is false

Open rishabh3112 opened this issue 4 years ago • 4 comments

What kind of change does this PR introduce? Fix

Did you add tests for your changes? Yup

If relevant, did you update the documentation? Yes

Summary No dev server when devServer: false is supplied.

Does this PR introduce a breaking change? Nope

Other information /cc @alexander-akait

rishabh3112 avatar Sep 13 '21 08:09 rishabh3112

Codecov Report

Merging #2947 (c18b084) into master (bd661fb) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.02%     
==========================================
  Files          22       22              
  Lines        1688     1692       +4     
  Branches      486      488       +2     
==========================================
+ Hits         1534     1538       +4     
  Misses        154      154              
Files Coverage Δ
packages/serve/src/index.ts 79.46% <ø> (ø)
packages/webpack-cli/src/webpack-cli.ts 92.63% <100.00%> (+0.02%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd661fb...c18b084. Read the comment docs.

codecov[bot] avatar Sep 13 '21 08:09 codecov[bot]

@alexander-akait devServer is object in schema, should change/publish that first to support devServer: false.

rishabh3112 avatar Sep 13 '21 08:09 rishabh3112

We should return before using schema

alexander-akait avatar Sep 13 '21 09:09 alexander-akait

We should return before using schema

We should not read configuration without validating against schema ideally.

rishabh3112 avatar Sep 16 '21 05:09 rishabh3112

We need to revert this, because we should not exit, just run a regular compilation with a warning, I will fix it

alexander-akait avatar Jan 04 '24 15:01 alexander-akait

Also webpack build with devServer: false should work too without any problems

alexander-akait avatar Jan 04 '24 15:01 alexander-akait