webpack-cli
webpack-cli copied to clipboard
fix: handle SIGINT with prompt
What kind of change does this PR introduce? fix
Did you add tests for your changes? WIP If relevant, did you update the documentation? NO Summary

Does this PR introduce a breaking change? No
Other information NO
Codecov Report
Merging #2887 (032291e) into master (77668d7) will decrease coverage by
0.02%
. The diff coverage is90.00%
.
@@ Coverage Diff @@
## master #2887 +/- ##
==========================================
- Coverage 94.96% 94.93% -0.03%
==========================================
Files 31 31
Lines 1708 1718 +10
Branches 486 486
==========================================
+ Hits 1622 1631 +9
- Misses 86 87 +1
Impacted Files | Coverage Δ | |
---|---|---|
packages/webpack-cli/lib/utils/prompt.js | 95.23% <90.00%> (-4.77%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 77668d7...032291e. Read the comment docs.
I am not sure how to mock CTRL + C
for tests here.
Just run process using execa
and send SIGINT
signal, no need to test CTRL + C
, because it can be changed by user
@snitin315 let's rebase, I think it is finished and please don't ignore windows tests, I will fix it if it will have problems