webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard

fix: handle SIGINT with prompt

Open snitin315 opened this issue 3 years ago • 4 comments

What kind of change does this PR introduce? fix

Did you add tests for your changes? WIP If relevant, did you update the documentation? NO Summary

Screenshot 2021-08-11 at 6 49 10 AM

Does this PR introduce a breaking change? No

Other information NO

snitin315 avatar Aug 11 '21 01:08 snitin315

Codecov Report

Merging #2887 (032291e) into master (77668d7) will decrease coverage by 0.02%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2887      +/-   ##
==========================================
- Coverage   94.96%   94.93%   -0.03%     
==========================================
  Files          31       31              
  Lines        1708     1718      +10     
  Branches      486      486              
==========================================
+ Hits         1622     1631       +9     
- Misses         86       87       +1     
Impacted Files Coverage Δ
packages/webpack-cli/lib/utils/prompt.js 95.23% <90.00%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77668d7...032291e. Read the comment docs.

codecov[bot] avatar Aug 11 '21 01:08 codecov[bot]

I am not sure how to mock CTRL + C for tests here.

snitin315 avatar Aug 16 '21 10:08 snitin315

Just run process using execa and send SIGINT signal, no need to test CTRL + C, because it can be changed by user

alexander-akait avatar Aug 16 '21 10:08 alexander-akait

@snitin315 let's rebase, I think it is finished and please don't ignore windows tests, I will fix it if it will have problems

alexander-akait avatar Apr 29 '23 18:04 alexander-akait