webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard

feat: install required packages for loading command automatically

Open snitin315 opened this issue 3 years ago • 5 comments

What kind of change does this PR introduce? feature

Did you add tests for your changes? WIP in tests If relevant, did you update the documentation? NA Summary

https://github.com/webpack/webpack-cli/pull/2809#issuecomment-870755830

Does this PR introduce a breaking change? No

Other information No

snitin315 avatar Jul 04 '21 13:07 snitin315

smoke tests passing locally 😞.

snitin315 avatar Jul 05 '21 09:07 snitin315

Yes, we should do it for all.

snitin315 avatar Jul 05 '21 11:07 snitin315

Codecov Report

Merging #2815 (88d24d9) into master (3e2bb73) will decrease coverage by 0.08%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2815      +/-   ##
==========================================
- Coverage   95.01%   94.93%   -0.09%     
==========================================
  Files          31       32       +1     
  Lines        1706     1717      +11     
  Branches      498      500       +2     
==========================================
+ Hits         1621     1630       +9     
- Misses         85       87       +2     
Impacted Files Coverage Δ
...kages/webpack-cli/lib/utils/prompt-installation.js 76.92% <71.42%> (+1.92%) :arrow_up:
packages/webpack-cli/lib/webpack-cli.js 96.87% <100.00%> (+<0.01%) :arrow_up:
packages/webpack-cli/lib/utils/run-command.js 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e2bb73...88d24d9. Read the comment docs.

codecov[bot] avatar Jul 26 '21 12:07 codecov[bot]

/cc @webpack/cli-team, Can someone check it locally on Linux/windows, all tests are passing on my macOS. (Missing prettier smoketests specially)

snitin315 avatar Jul 26 '21 12:07 snitin315

@snitin315 Do we need this, I just checked and we don't ask about installation when I use webpack init

alexander-akait avatar May 04 '23 02:05 alexander-akait