webpack-cli icon indicating copy to clipboard operation
webpack-cli copied to clipboard

feat: improve performance

Open anshumanv opened this issue 3 years ago • 7 comments

What kind of change does this PR introduce?

performance

Did you add tests for your changes? existing

If relevant, did you update the documentation? NA

Summary

  • Improve performance
  • inbuiltOptions as object
  • unnecessary iterations purged

Does this PR introduce a breaking change? no

Other information

anshumanv avatar Apr 14 '21 15:04 anshumanv

Looking at CI

anshumanv avatar Apr 14 '21 15:04 anshumanv

Codecov Report

Merging #2626 (b24a8a5) into master (281f8ef) will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
- Coverage   95.23%   95.19%   -0.05%     
==========================================
  Files          31       30       -1     
  Lines        1512     1499      -13     
  Branches      429      428       -1     
==========================================
- Hits         1440     1427      -13     
  Misses         72       72              
Impacted Files Coverage Δ
packages/serve/src/index.ts 91.22% <100.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 96.15% <100.00%> (+<0.01%) :arrow_up:
packages/generators/src/addon-generator.ts 93.18% <0.00%> (ø)
packages/generators/src/utils/copy-utils.ts

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 281f8ef...b24a8a5. Read the comment docs.

codecov[bot] avatar Apr 14 '21 21:04 codecov[bot]

Looks like some spacing diff in help output

anshumanv avatar Apr 15 '21 05:04 anshumanv

Try a rebase.

snitin315 avatar Apr 15 '21 10:04 snitin315

hm looks like no help

anshumanv avatar Apr 15 '21 12:04 anshumanv

Found more places to improve perf, I will finish it

alexander-akait avatar Apr 21 '21 17:04 alexander-akait

Big thanks! 👍

anshumanv avatar Apr 21 '21 18:04 anshumanv