schema-utils icon indicating copy to clipboard operation
schema-utils copied to clipboard

feat: humanize format

Open vankop opened this issue 5 years ago • 2 comments

This PR contains a:

  • [ ] bugfix
  • [x] new feature
  • [ ] code refactor
  • [x] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

#66

Breaking Changes

Yes

Additional Info

I think it is a point to discuss, should schema-utils move absolutePath to custom format instead of keyword

vankop avatar Oct 13 '19 17:10 vankop

Codecov Report

Merging #68 (d3eb673) into master (7fc8069) will decrease coverage by 0.09%. The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   98.57%   98.47%   -0.10%     
==========================================
  Files           5        6       +1     
  Lines         561      592      +31     
  Branches      252      259       +7     
==========================================
+ Hits          553      583      +30     
- Misses          8        9       +1     
Impacted Files Coverage Δ
src/util/humanize.js 96.29% <96.29%> (ø)
src/ValidationError.js 98.16% <100.00%> (+<0.01%) :arrow_up:
src/keywords/absolutePath.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7fc8069...d3eb673. Read the comment docs.

codecov[bot] avatar Oct 13 '19 17:10 codecov[bot]

/cc @vankop we can continue a work on the PR

alexander-akait avatar Nov 12 '19 12:11 alexander-akait