docs icon indicating copy to clipboard operation
docs copied to clipboard

Update docs for NoErrorsPlugin deprecation and rename to NoEmitOnErrorsPlugin

Open zachlysobey opened this issue 8 years ago • 7 comments

The NoErrorsPlugin was deprecated in webpack PR#3570 and renamed to NoEmitOnErrorsPlugin

The docs here should probably be updated to reflect that.

zachlysobey avatar Feb 06 '17 15:02 zachlysobey

Does this still apply, now that Doc github repo moved? There seems to be no reference to none of the two in https://webpack.js.org/configuration/plugins/, nor in https://github.com/webpack/webpack.js.org/tree/master/content/plugins

BrainCrumbz avatar Mar 01 '17 21:03 BrainCrumbz

@BrainCrumbz I'm not really clear on where any docs have moved, or what the plan is moving forward,... but the docs I linked to still exist, and are still incomplete/misleading. If these are not the current docs, then I would guess that they should be removed, and replaced with a redirect or a link to the current documentation.

zachlysobey avatar Mar 01 '17 21:03 zachlysobey

Did you check this project home? The big prints says that they moved to https://github.com/webpack/webpack.js.org, that changes here should be done on local wiki, but then again it says to submit issues/PRs at the new repo.

So I guess a good move could be to either apply the change directly to wiki plugin list or move this issue to the new repo.

Just sayin'...

BrainCrumbz avatar Mar 01 '17 22:03 BrainCrumbz

I also used NoErrorsPlugin in an old project, just check plugins page and still don't see NoEmitOnErrorsPlugin there 👎

tiendq avatar Apr 21 '17 11:04 tiendq

I see noEmitOnErrorsPlugin here: https://webpack.js.org/plugins/no-emit-on-errors-plugin/

jwineman avatar Mar 06 '18 01:03 jwineman

I see it on VSCode is already deprecated too and there is suggestion to use config.optimization.noEmitOnErrors

mernstackman avatar Mar 01 '19 13:03 mernstackman

So I tried optimization.noEmitOnErrors, but optimization is not a valid configuration key for webpack THREE - so I renamed the plugin from:

    plugins: [
        new webpack.NoErrorsPlugin(),

to:

    plugins: [
        new webpack.NoEmitOnErrorsPlugin(),

The deprecation warning is gone, so I guess handling this for webpack3 is as easy as just renaming the plugin.

devinrhode2 avatar Mar 05 '19 17:03 devinrhode2