analyse-tool icon indicating copy to clipboard operation
analyse-tool copied to clipboard

Bootstrapping the basic infrastructure

Open alajmo opened this issue 9 years ago • 7 comments

So, we've chosen the team, the team leaders, drawn upon some of the major features, I think the next step is actually getting the basic infrastructure ready. According to the roadmap, we should be doing the UI design, but I think data > view / presentation, especially since it seems we're not actually sure about what to present.

Setting up the infrastructure (router, store, pages, folders, compontents etc) is agnostic to how the view actually ends up looking like and if we can get this done before, it will be much easier to handle the view.

So, my proposal is, let's give ourselves 3 days to determine the infrastructure and frameworks / tools we're going to use and move forward.

I think it's crucial we get something working as soon as possible.

alajmo avatar Nov 25 '15 18:11 alajmo

I think it should be

  • [ ] React/Redux (obviously).
  • [ ] Devtools and thunk as redux middleware.
  • [ ] For tests I don't really know what is better, everyone seems to use different tools and I don't know whats the best. I think we can use jest/jsdom for starters.
  • [ ] ESlint and airbnb style guide.
  • [ ] ES6 classes for React components

zaggy avatar Nov 25 '15 23:11 zaggy

echo @zaggy's suggestions - @sokra has provided us a reasonable skeleton to work with as well. however, to be a little more consistent with the other projects in the webpack org (notably, webpack itself), i'd advocate for mocha/jsdom as we'll have more than enough existing examples to work off of.

as for routers, react-router is a quite an amazing library, and should serve our purposes nicely.

jnwng avatar Nov 26 '15 01:11 jnwng

I like the simplicity of using tape for testing, it works both in the browser and node and we can avoid having one more config file.

One more question, should we use a starter-kit or configure the whole thing ourselves from scratch?

alajmo avatar Nov 26 '15 06:11 alajmo

I've never used tape, don't know what other think of it. And I hate using starter-kits as they all are overloaded with stuff, that is good for a newcomer, but does not really suit us.

zaggy avatar Nov 26 '15 07:11 zaggy

I've created a PR (#7) with tape and karma. Kept the config as minimal as possible.

msuntharesan avatar Nov 30 '15 18:11 msuntharesan

Totally agree with @jnwng to use mocha and try to keep the libraries uniform within the webpack org.

timaschew avatar Dec 03 '15 13:12 timaschew

It would also be great if you can keep the code style similar to the other repos in the webpack org, but that is not a total must have for me.

sokra avatar Dec 03 '15 17:12 sokra