worker-loader icon indicating copy to clipboard operation
worker-loader copied to clipboard

fix: make inline workers work from IE/Edge legacy

Open elasim opened this issue 3 years ago • 6 comments

This PR contains a:

  • [x] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

  • Fix inline worker to work on IE11 and Edge legacy.
  • This PR will resolve an issue #292.

Breaking Changes

No breaking changes.

Additional Info

N/A

elasim avatar May 11 '21 16:05 elasim

Codecov Report

Merging #316 (3b1e9d2) into master (22275e9) will decrease coverage by 22.19%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #316       +/-   ##
===========================================
- Coverage   75.83%   53.64%   -22.20%     
===========================================
  Files           6        6               
  Lines         149      151        +2     
  Branches       52       53        +1     
===========================================
- Hits          113       81       -32     
- Misses         30       54       +24     
- Partials        6       16       +10     
Impacted Files Coverage Δ
src/runtime/inline.js 0.00% <0.00%> (ø)
src/supportWebpack5.js 0.00% <0.00%> (-83.34%) :arrow_down:
src/index.js 82.50% <0.00%> (-12.50%) :arrow_down:
src/utils.js 81.57% <0.00%> (-5.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22275e9...3b1e9d2. Read the comment docs.

codecov[bot] avatar May 11 '21 16:05 codecov[bot]

Can you accept CLA?

alexander-akait avatar May 11 '21 17:05 alexander-akait

Okay. I accepted CLA.

elasim avatar May 11 '21 17:05 elasim

I will fix tests tomorrow and do release

alexander-akait avatar May 11 '21 17:05 alexander-akait

Good. Thanks for your efforts.

elasim avatar May 11 '21 17:05 elasim

I've found a minor glitch for this approach.

https://github.com/webpack-contrib/worker-loader/issues/292#issuecomment-839061164

elasim avatar May 11 '21 19:05 elasim