webpack-hot-middleware
webpack-hot-middleware copied to clipboard
webpack-contrib
WIP: webpack 5 support
This PR contains a:
- [x] bugfix
- [ ] new feature
- [ ] code refactor
- [ ] test update
- [ ] typo fix
- [ ] metadata update
Motivation / Use-Case
Webpack 5 made some changes, which have broken error handling functions in hot middleware
Breaking Changes
None, this should remain compatible with v4.
I intend to configure CI to run the tests against v4 as a bit of insurance for this.
Additional Info
Supercedes #393
Will either incorporate the fix from #394 or some equivalent once the error is fully understood
Ready for review?
I'm happy to take notes on this, but i'm not intending to merge until the fix (or an equivalent) to #394 is included - and I want to understand exactly what's changed before applying that fix.
Would be nice to get this reviewed and merged. Even if it only fixes 80% of webpack 5 integration.
Does the "bugfix" checkbox in the PR description also cover documentation updates? I wouldn't consider out-of-date docs as a "bug", but each to their own...
Also i second that this is important to expedite.
The fix will be released when what changed in webpack 5 is understood and then a fix can be developed.
If anyone is waiting on this and wants to help, investigating what the exact behaviour change in v5 was would be useful.
On 13 Mar 2021, at 23:56, Wei @.***> wrote:
any updates on when we could get the fixes release?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
@glenjamin I am not 100% sure the issue, but I think it is related this middleware’s functions are not injecting to webpack 5 entry. E.g.: overlay and reload are both not working. With webpack 4 I can see the reload script is in the html, but not with webpack 5.
@sokra the community struggles with this bug, can you please spend some time and advice on what was changed and how to migrate?
@alexander-akait there were some API changes in webpack 5 related to how it works with plugins (correct me if i'm wrong but I believe context was changed) . as a result hot-middleware is broken. community managed to write monkey patch which pretends that every update has failed and reloads module. Here is the code
https://github.com/webpack-contrib/webpack-hot-middleware/pull/394/files
The author of this lib is not working with this stack any more and does not seem to be interested to fix his code but is responsive and will accept PR if any So the best thing I can do is to ask for help from webpack side. Maybe you guys can spare couple of hours and to point out the way how to properly migrate
If/when I get time to poke at this a little deeper, my plan would be to:
- using the example project on webpack 4, run through the main scenarios for success/error/unaccepted, note which event handlers fire
- upgrade to webpack 5, repeat scenarios, note what the difference is
- understand why there is a difference, referencing changes in webpack's source and other hot reload clients
- either submit a bug to webpack, or adjust this module to handle the changes
If there are people who need this to work, they should be able to follow these steps themselves to work towards an understanding and then a solution.
We have a fork of whm at gatsby that we're currently using in "Production" which works with fast-refresh, ...
Changes we did on top of it are: https://github.com/gatsbyjs/webpack-hot-middleware/commit/4ea7d5993921fc601ae7430081329d70dd073a18
I did not check for webpack 4 compatibility.
@wardpeet Your fork for the overlay is not working.
'webpack-hot-middleware/client?path=/__webpack_hmr&reload=true&overlay=true'
Is there any update on this? Maybe you could add a warning on the README warning that webpack 5 is not fully supported yet, since I had a hard time finding this issue
@mcat95 you can check this issue https://github.com/webpack/webpack/issues/12408
After some tests, I can confirm that the fix proposed in fork https://github.com/lukeapage/webpack-hot-middleware#2cdfe0d0111dab6432b8683112fd2d17a5e80572 is working on Webpack 5. Good work, lukeapage!
Any chance this gets merged? Fixes the overlay issue for our stack and it's always good to have at least partial support then none
Any chance this gets merged? Fixes the overlay issue for our stack and it's always good to have at least partial support then none
So there was supposedly a fix merged for the related issue https://github.com/webpack/webpack/issues/12408, released with webpack 5.72.0, but when I look at that PR...I only see some test cases updated? I might not understand what those files in the PR actually impact...
@chucknelson fix was in separate PR, in mentioned PR only test cases..
Thanks @vankop - I can't find the PR or commit for the actual fix. Do you happen to have a link to that PR?
I spent a little time understanding what the remaining outstanding issue is - it does appear to be a change in webpack core, so I'm going to try and produce a minimal reproduction case and follow up there.
If anyone knows of existing reports that aren't already linked from here - please do comment with links.
The Problem Scenario
- Save a file with a syntax error
- The error overlay shows up
- Fix the syntax error and save the file
- The error overlay closes
- The file that had the error will now no-longer apply hot updates
In webpack 5
- The first update notes the bundle has errors, and does not apply
- The second update applies the broken bundle
- which causes the
apply()of that module to error withself-accept-errored
- which causes the
- Future updates claim to update the broken module, but don't actually do anything
In webpack 4
- The above scenario works correctly, and the module can be updated.
- The first update notes the bundle has errors, and does not apply
- The second update applies the now fixed bundle
- If a module breaks with
self-accept-errored(eg. throws insideif (module.hot) { ...), then future updates will error as unaccepted - rather than claiming to work and doing nothing
Any update on this? Or does anyone have a good replacement for this library?
