webpack-hot-middleware
webpack-hot-middleware copied to clipboard
feat(client): provide option for disabling console warn messages
add noWarn client parameter
resolves #319
This PR contains a:
- [ ] bugfix
- [x] new feature
- [ ] code refactor
- [ ] test update
- [ ] typo fix
- [ ] metadata update
Motivation / Use-Case
Add support for disabling console.warn messages on the client.
Resolves #319
Breaking Changes
Additional Info
Codecov Report
Merging #321 into master will decrease coverage by
0.32%. The diff coverage is50%.
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 87.5% 87.17% -0.33%
==========================================
Files 3 3
Lines 232 234 +2
Branches 65 66 +1
==========================================
+ Hits 203 204 +1
- Misses 29 30 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| client.js | 85.18% <50%> (-0.44%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8d46df6...cc76b8e. Read the comment docs.
Unfortunately, the internal warn variable is poorly named, setting it to true will also hide error logging.
Ah, ok didn't realize that. I'll take a closer look.
@jgraniero Are you still working on this? We have the exact same use case you originally reported. Thank you for trying to add warningsFilter support ❤️
Yea, been super busy so haven't had the time to revisit this yet, but I'm trying!
No pressure. Thank you for looking into this.
Codecov Report
Merging #321 into master will decrease coverage by
0.32%. The diff coverage is50.00%.
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 87.50% 87.17% -0.33%
==========================================
Files 3 3
Lines 232 234 +2
Branches 65 66 +1
==========================================
+ Hits 203 204 +1
- Misses 29 30 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| client.js | 85.18% <50.00%> (-0.44%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8d46df6...cc76b8e. Read the comment docs.